Declaration-order-dependent possibly-undefined false positive with nested ifs/matches, decorated any functions and NoReturn
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
Bug Report
Some obtuse code results in a false positive for the possibly-undefined error code.
To Reproduce
Run mypy --enable-error-code possibly-undefined file.py on this file:
decorator = lambda f: f
def unreachable() -> None:
raise NotImplementedError()
def do_it(x: bool, y: None) -> None:
if x:
decorated()
var = 0
else:
match y:
case None:
var = 1
case _:
unreachable()
print(var)
@decorator
def decorated() -> None:
pass
This is as small as I've gotten the reproducer. All these parts seem to be significant:
- the outer
ifand an innermatch - the
decoratedcall being separate to thematch - the
matchbeing amatch(replacing thematchwith the equivalentif y is None: ... else: ...construct works fine) - the
matchhaving exhaustive arms with theunreachablecall being unreachable (as far as mypy can tell) (e.g. deleting thecase None:entirely works fine) - the
unreachablecall existing (inliningcase _: raise NotImplementedError()works fine) decoratorbeing a lambda (or an class with__call__method) (usingdef decorator(f): return fworks fine)decoratedbeing defined afterdo_itin the file (changing the order works fine) (NB. it's justdecorated,decoratorandunreachablecan be defined before or afterdo_itand still reproduce the behaviour)
Expected Behavior
This to pass type checking.
In particular, have same behaviour as any of the very similar ablations mentioned above, e.g. both of these work:
- changing
decorator = lambda f: ftodef decorator(f): return f - moving
decoratedto be beforedo_it
Actual Behavior
file.py:19: error: Name "var" may be undefined [possibly-undefined]
Found 1 error in 1 file (checked 1 source file)
Your Environment
- Mypy version used: 1.11.2
- Mypy command-line flags:
--enable-error-code possibly-undefined - Mypy configuration options from
mypy.ini(and other config files): None - Python version used: 3.10
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the minimal file.py reproducer and run mypy --enable-error-code possibly-undefined to confirm the reported diagnostic. Compare the listed ablations, including the decorator definition, declaration order, and match branches, to isolate the interaction. Done means the reproducer passes type checking without the false positive.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100