python / python/mypy

(🐞) `--update-data` removes escapes

Open
#17,465 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug priority-2-low topic-tests
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

[case testSomethingSus]
\[1] + 1
> pytest mypy --update-data

Expected

[case testSomethingSus]
\[1] + 1  # E: Something sus  [sus]

Actual

[case testSomethingSus]
[1] + 1  # E: Something sus  [sus]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the shown test data and pytest mypy --update-data. Trace the update-data path responsible for rewriting the [1] + 1 line; done means the escaped \[1] remains escaped while the diagnostic comment is added as shown.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.