python / python/mypy

Inconsistent optional type resolution for AbstractSet and Set

Open
#16,964 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

Bug Report

Inconsistent optional type resolution for AbstractSet and Set.

To Reproduce

from typing import AbstractSet, Set


def check(x: int) -> None: ...


def foo(x: int | None, s: AbstractSet[int]) -> None:
    if x in s:
        check(x)  # error: Argument 1 to "check" has incompatible type "int | None"; expected "int"  [arg-type]


def bar(x: int | None, s: Set[int]) -> None:
    if x in s:
        check(x)  # no error

Expected Behavior

The resolved type after x in AbstractSet and Set should be the same.

If it needs to be consistent with other type unions, the additional type resolution should not happen:

(this is how it currently works for int | str, no additional type resolution happens)

from typing import AbstractSet, Set


def check(x: int) -> None: ...

def foo(x: int | str, s: AbstractSet[int]) -> None:
    if x in s:
        check(x)  # error


def bar(x: int | str, s: Set[int]) -> None:
    if x in s:
        check(x)  # error

Actual Behavior

In a branch where x of Optional[T] is in Set[T], x's type is resolved into T, however that does not happen with AbstractSet.

Your Environment

  • Mypy version used: 1.8.0
  • Mypy command-line flags: with and without --strict
  • Mypy configuration options from mypy.ini (and other config files): none
  • Python version used: 3.12

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the provided Python reproducer with mypy 1.8.0 and compare the AbstractSet and Set cases in foo and bar. Trace the type narrowing performed for x in each collection and add coverage for the reported behavior. Done means both collection types resolve the optional value consistently with the chosen expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.