`explicit-override` false positive when overriding property with setter
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
# mypy: enable-error-code=explicit-override
from typing_extensions import override
class Foo:
@property
def foo(self) -> int:
return 1
@foo.setter
def foo(self, value: int) -> None:
...
class Bar(Foo):
@property # error: explicit-override
@override
def foo(self) -> int:
return 2
@foo.setter
def foo(self, value: int) -> None:
...
putting @override on the setter does not fix it (and it shouldn't be required anyway, as that would be inconsistent with other decorators such as @abstractmethod)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the issue's minimal example in the linked mypy playground and confirm the false positive on the property decorator. Trace the explicit-override handling for a property overridden with a getter and setter. Done means the getter can carry @override without an error, and decorating the setter is not required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100