[stubtest] Support `@final` decorator on methods as well
Open
Nobody has claimed this yet.
feature
topic-final
topic-stubtest
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
After https://github.com/python/mypy/pull/14922 is merged, I think we can also add a check that this source code has correct stubs:
class A:
@final
def method(self): ...
Right now stubs do not have to add @final decorator, stubtest will allow both versions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing stubtest's existing checks for decorators on classes and methods, then find the related tests or fixtures. Add coverage for a method decorated with @final so matching stubs require the decorator, and verify that missing or extra decorators produce the expected result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools, testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100