Property setter not accepted if not next to getter

Open

#1,465 opened on May 2, 2016 10 comments 51 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 35/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: python
Domain: devtools

Research direction

Start by running the minimal reproducer in mypytest.py and confirm that inserting _other between the property getter and setter produces the diagnostic. Trace mypy's handling of property setters and add regression coverage; done means the separated setter is accepted without the Callable attribute error.

Written by the indexing model from the issue text.

Description

bug false-positive priority-1-normal topic-descriptors

The following code incorrectly raises an error:

class Config(object):

    @property
    def my_proprty(self):
        return None

    def _other(self):
        pass

    @my_proprty.setter
    def my_proprty(self, val):
        pass

Error:

mypytest.py: note: In class "Config":
mypytest.py:12: error: Callable[[Any], Any] has no attribute "setter"

Commenting out the _other method will fix the error.

Dominant language: Python
Stars: 20.6k
Forks: 3.3k
Avg merge: 1d 18h
Merged PRs (30d): 54

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.