python / python/mypy

(🐞) `isinstance` with generic type narrows the generic parameters to `Any` when it should narrow to a safe type

Open
#12,146 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug topic-type-narrowing
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

a: object
if isinstance(a, list):
    reveal_type(a) # list[Any]
    b = a[0] # Any

Why is a narrowed to list[Any]? It should be narrowed to list[T_co] where T_co = TypeVar("T_co", covariant=True)

related: #12015

also:

i: Iterable[int]
assert isinstance(i, list):
reveal_type(i) # list[Any]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the two examples in the issue and inspect how isinstance narrows generic types in mypy's type-checking path. Compare the behavior with related issue #12015. Done means list values retain a safe generic element type rather than becoming list[Any], including when narrowing Iterable[int].

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.