`classmethod`s shouldn't be allowed to access generic attributes
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
from typing import Generic, TypeVar
T = TypeVar("T")
class A(Generic[T]):
class_attr: T
@classmethod
def set_attr(cls, arg: T) -> None:
cls.class_attr = arg # no error?
B = A[str]
B.set_attr("1")
B.class_attr = "1" # error: Access to generic instance variables via class is ambiguous
C = A[int]
C.set_attr(1)
C.class_attr = 1 # error: Access to generic instance variables via class is ambiguous
value = B().class_attr
reveal_type(value) # revealed: str, actual value: int
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the standalone Python reproduction in the issue and compare the diagnostics for classmethod access with direct class assignment. The fix is complete when generic attributes accessed through a classmethod are rejected consistently and the revealed type cannot become unsound; no source file or test path is named.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100