Mypy daemon + `--namespace-packages` mishandles deletion of `__init__.py`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
Bug Report
Run mypy with --namespace-packages flag.
If daemon is initially run with
p/__init__.py
p/a.py
Then delete p/__init__.py
We expect p to become a namespace package and p.a to be resolvable still. This does not happen.
The issue exists within the daemon update logic (update.py).
If we initialize the daemon with only
p/a.py
things work ok.
Issue was discovered via #11259 and #9636 for context
To Reproduce
In test-data/unit/fine-grained-modules.test, add to the first line of the following tests testDeletePackage4, testDeletePackage5, and testDeletePackage6
# flags: --namespace-packages
Can run the test with
source .tox/py37/bin/activate
pytest mypy/test/testfinegrained.py -k testDeletePackage4 -n0
Expected Behavior
for testDeletePackage4
main:3: error: Argument 1 to "f" has incompatible type "int"; expected "str...
==
main:3: error: Argument 1 to "f" has incompatible type "int"; expected "str...
== (diff)
main:2: error: Cannot find implementation or library stub for module named "p.a" (diff)
main:2: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports (diff)
main:2: error: Cannot find implementation or library stub for module named "p" (diff)
Actual Behavior
for testDeletePackage4
main:3: error: Argument 1 to "f" has incompatible type "int"; expected "str...
==
main:2: error: Import of "p.a" ignored (diff)
main:2: note: (Using --follow-imports=error, module not passed on command line) (diff)
== (diff)
main:2: error: Cannot find implementation or library stub for module named "p.a" (diff)
main:2: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports (diff)
main:2: error: Cannot find implementation or library stub for module named "p" (diff)
Ideally when fixing this task - we should convert the three aformentioned tests to use --namespace-packages
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the daemon update logic in update.py and the test cases in test-data/unit/fine-grained-modules.test, especially testDeletePackage4, testDeletePackage5, and testDeletePackage6. Run pytest mypy/test/testfinegrained.py -k testDeletePackage4 -n0 with --namespace-packages enabled, then verify the three tests preserve p.a resolution after init.py is deleted and match the expected diagnostics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100