Reject assignments when `__setattr__` has NoReturn return type

Open
#1,052 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
devtools

Research direction

Start by reviewing the behavior described in issue #1052 and its relation to #521, then locate the type-checking path for attribute assignments and __setattr__ return annotations. Verify the example class and confirm that assignments through both A and self are rejected when __setattr__ has a NoReturn return type.

Written by the indexing model from the issue text.

Description

feature priority-1-normal

Consider this class:

class A:
    def __setattr__(self, x, y):
        raise RuntimeError

The above implementation should be considered special and all attribute assignments via A, including via self should be rejected.

This is related to #521 (general __setattr__ support).

Dominant language
Python
Stars
20.6k
Forks
3.3k
Avg merge
1d 18h
Merged PRs (30d)
54

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/mypy

All issues in python/mypy

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.