POSIX multiprocessing spawn performance becomes 10x slower from a certain pickle size
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- linux, python
- Domain
- operating-systems, performance
Research direction
Reproduce the timing difference with mp_pipe_limits.py on Python 3.9 or 3.10, then inspect multiprocessing/popen_spawn_posix.py around pipe creation and reduction.dump. Compare behavior at 65536 and 65537 bytes and determine a fix that avoids the performance cliff; done means the reproduction no longer shows the reported slowdown without relying on an unsafe fixed pipe size.
Written by the indexing model from the issue text.
Description
Bug report
We are using multiprocessing with the spawn start method. On my 32-thread PC, starting all worker processes for my project used to take 2 seconds. At a certain point, it jumped straight to taking 20 seconds.
The slowdown appears as soon as more than 64 KB needs to be sent to a child process over the pipe.
Consider this minimal reproduction case:
#!/usr/bin/python3
import multiprocessing
import random
import sys
import time
class Container:
def __init__(self, size):
self.data = random.randbytes(size)
class ChildProcess(multiprocessing.Process):
def __init__(self, name: str, container):
super().__init__(name=name)
self.container = container
def run(self) -> None:
print("Running")
def run():
fixed_overhead_3_9 = 885
difference = int(sys.argv[1])
container = Container((64*1024) - fixed_overhead_3_9 + difference)
children = [ChildProcess(f"child-{i}", container) for i in range(0, 2)]
start_time = time.perf_counter()
for child in children:
child.start()
end_time = time.perf_counter()
print(f"Running took {int((end_time - start_time) * 1000)}ms")
for child in children:
child.join()
if __name__ == "__main__":
multiprocessing.set_start_method("spawn")
run()
I added some "instrumentation" in multiprocessing/popen_spawn_posix.py to print the buffer size:
try:
reduction.dump(prep_data, fp)
reduction.dump(process_obj, fp)
finally:
set_spawning_popen(None)
print(len(fp.getbuffer()))
parent_r = child_w = child_r = parent_w = None
Running the example results in:
$ python3.9 mp_pipe_limits.py 0
65536
65536
Running took 9ms
Running
Running
$ python3.9 mp_pipe_limits.py 1
65537
65537
Running
Running took 96ms
Running
Changing the pipe size with fcntl in multiprocessing/popen_spawn_posix.py restores performance:
parent_r = child_w = child_r = parent_w = None
try:
parent_r, child_w = os.pipe()
child_r, parent_w = os.pipe()
fcntl.fcntl(parent_w, 1031, 100000)
cmd = spawn.get_command_line(tracker_fd=tracker_fd,
pipe_handle=child_r)
Where 1031 is fcntl.F_SETPIPE_SZ, which is not in Python 3.9.
Rerunning the reproduction case after this change:
$ python3.9 mp_pipe_limits.py 1
65537
65537
Running took 9ms
Running
Running
Of course, changing the pipe size will only delay the onset of the problem. The real solution (if there is any) will probably be different. Blindly setting a pipe size might also not be safe as it depends on limits set in /proc.
The example above is a best case example, since it has very limited pickle overhead. We hit this limit without any data caches involved. It's just our Python objects that live after application initialization. They are slower to pickle. However, then things are still 10x slower, so not just a fixed 80ms as seen in the example.
We use spawn instead of fork on Linux to avoid troubles with objects that cannot be pickled on other OSs (Windows).
Your environment
- CPython versions tested on: 3.9 and 3.10
- Operating system and architecture: Arch Linux (kernel 5.19.9-arch1-1), x86_64
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 36k
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 558
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from python/cpython
-
docs pending
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
stdlib type-feature
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
stdlib type-feature
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
build type-bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
stdlib topic-email type-feature
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
🐛 Bug 🔔 Pending processing
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
jumpserver/jumpserver#17584 ·