urljoin works incorrectly for two path-relative URLs involving . and ..
Open
@serhiy-storchaka is already working on this.
Since Nov 11, 2024.
stdlib
type-feature
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 36k
- PR merge metrics
- PR metrics pending
Description
Bug report
urllib.parse.urljoin is usually used to join a normalized absolute URL with a relative URL, and it generally works for that purpose. But if it’s used to join two path-relative URLs, it produces incorrect results in many cases when . or .. is involved.
>>> from urllib.parse import urljoin
>>> urljoin('a', 'b') # ok
'b'
>>> urljoin('a/', 'b') # ok
'a/b'
>>> urljoin('a', '.') # expected . or ./
'/'
>>> urljoin('a', '..') # expected .. or ../
'/'
>>> urljoin('..', 'b') # expected ../b
'b'
>>> urljoin('../a', 'b') # expected ../b
'b'
>>> urljoin('a', '../b') # expected ../b
'b'
>>> urljoin('../a', '../b') # expected ../../b
'b'
>>> urljoin('a/..', 'b') # expected b
'a/b'
There are also some problems when the base is a non-normalized absolute URL:
>>> urljoin('http://host/a/..', 'b') # expected http://host/b
'http://host/a/b'
Your environment
- CPython versions tested on: 3.10.5, 3.11.0rc1
- Operating system and architecture: NixOS 21.11 amd64
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.