python / python/cpython

prevent asynccontextmanager and sync contextmanager drifting

Open
#95,902 1 comment 0 reactions 1 assignee View on GitHub

@graingert is already working on this.

Since Aug 11, 2022.

tests type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
PR metrics pending

Description

I think by adopting the testing approach taken by AsyncExitStack and ExitStack for contextlib.contextmanager it should be possible to prevent contextlib.asynccontextmanager from drifting in implementation

class TestAsyncExitStack(TestBaseExitStack, unittest.TestCase):
    class SyncAsyncExitStack(AsyncExitStack):

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.