PY_CHECK_SQLITE_FUNC() adds -lsqlite3 multiple times
Open
@erlend-aasland is already working on this.
Since Jun 23, 2022.
3.11
3.12
3.13
build
type-bug
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 36k
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 558
Description
Bug report
The configure.ac macro PY_CHECK_SQLITE_FUNC keeps on adding -lsqlite3 over and over again. This seems to cause some problems on Emscripten with a static libsqlite3.a file.
configure:12473: checking for sqlite3.h
configure:12473: result: yes
configure:12496: gcc -c -I$(srcdir)/Modules/_sqlite conftest.c >&5
configure:12496: $? = 0
configure:12500: checking for sqlite3_bind_double in -lsqlite3
configure:12525: gcc -o conftest -I$(srcdir)/Modules/_sqlite -lsqlite3 conftest.c -lsqlite3 -ldl >&5
configure:12525: $? = 0
configure:12534: result: yes
configure:12551: checking for sqlite3_column_decltype in -lsqlite3
configure:12576: gcc -o conftest -I$(srcdir)/Modules/_sqlite -lsqlite3 conftest.c -lsqlite3 -lsqlite3 -ldl >&5
configure:12576: $? = 0
configure:12585: result: yes
...
configure:12806: checking for sqlite3_result_double in -lsqlite3
configure:12831: gcc -o conftest -I$(srcdir)/Modules/_sqlite -lsqlite3 conftest.c -lsqlite3 -lsqlite3 -lsqlite3 -lsqlite3 -lsqlite3 -lsqlite3 -lsqlite3 -ldl >&5
Erlend is going to look into the problem.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.