python / python/cpython

Split up _testcapimodule.c

Open
#93,649 38 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tests topic-C-API type-refactor
Dominant language
Python
Stars
77.2k
Forks
36k
Avg merge
1d 9h
Merged PRs (30d)
558

Description

Modules/_testcapimodule.c is a nearly-8000-line behemoth with no clear structure or organization. It is getting hard to maintain.

It also doesn't work well with testing (a) feature macros that affect Python.h and (b) module initialization, so we have additional C-API testing modules: _testmultiphase, _testimportmultiple, _testinternalcapi.
_testbuffer is already split out, but there are many other aspects of the API that would use a similar dedicated test suite.

We should split and combine these, ideally without polluting the namespace of top-level modules.

  • PR: gh-94549
  • PR: gh-94695
  • PR: gh-94702
  • PR: gh-95386
  • PR: gh-95793
  • PR: gh-95819
  • PR: gh-99346
  • PR: gh-99494
  • PR: gh-99517
  • PR: gh-99532
  • PR: gh-99549
  • PR: gh-99551
  • PR: gh-102173
  • PR: gh-104403
  • PR: gh-129400
  • PR: gh-129512
  • PR: gh-129516
  • PR: gh-129521
  • PR: gh-129544

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing Modules/_testcapimodule.c and the existing _testmultiphase, _testimportmultiple, _testinternalcapi, and _testbuffer modules, then examine the linked PRs listed in the issue. Done means the C-API tests are split into coherent modules, the relevant testing coverage is preserved, and top-level module namespace pollution is avoided.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, python
Domain
testing-qa
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.