ast.unparse produces bad code for identifiers that become keywords

Open
#90,678 17 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
compilers

Research direction

Start by reviewing PR python/cpython#31012 and the ast.unparse behavior described in the issue. Reproduce a case where an identifier becomes a keyword, then inspect the related AST unparser tests if the pull request identifies them. Done means ast.unparse no longer produces invalid code for that case and regression coverage is present.

Written by the indexing model from the issue text.

Description

3.10 3.11 3.9 (EOL) stdlib type-bug
BPO 46520
Nosy @terryjreedy, @benjaminp, @JelleZijlstra, @Kodiologist, @pablogsal, @isidentical, @sobolevn
PRs
  • python/cpython#31012
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2022-01-25.15:06:17.083>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = 'ast.unparse produces bad code for identifiers that become keywords'
updated_at = <Date 2022-01-29.18:06:22.414>
user = 'https://github.com/Kodiologist'

    bugs.python.org fields:

    activity = <Date 2022-01-29.18:06:22.414>
actor = 'Kodiologist'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2022-01-25.15:06:17.083>
creator = 'Kodiologist'
dependencies = []
files = []
hgrepos = []
issue_num = 46520
keywords = ['patch']
message_count = 7.0
messages = ['411606', '411669', '411742', '411780', '411781', '412045', '412078']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'benjamin.peterson', 'JelleZijlstra', 'Kodiologist', 'pablogsal', 'BTaskaya', 'sobolevn']
pr_nums = ['31012']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46520'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.