python / python/cpython

__instancecheck__ being checked on type(cls) instead of cls

Open
#89,949 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.11 3.12 3.13 interpreter-core
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 45791
Nosy @gvanrossum, @rhettinger, @benjaminp, @serhiy-storchaka, @brandtbucher
PRs
  • python/cpython#29540
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2021-11-12.05:01:11.036>
    labels = ['interpreter-core', '3.9', '3.10', '3.11']
    title = '__instancecheck__ being checked on type(cls) instead of cls'
    updated_at = <Date 2021-11-13.15:44:36.246>
    user = 'https://github.com/rhettinger'
    

    bugs.python.org fields:

    activity = <Date 2021-11-13.15:44:36.246>
    actor = 'brandtbucher'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Interpreter Core']
    creation = <Date 2021-11-12.05:01:11.036>
    creator = 'rhettinger'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45791
    keywords = ['patch']
    message_count = 11.0
    messages = ['406187', '406191', '406193', '406219', '406222', '406226', '406227', '406229', '406230', '406237', '406245']
    nosy_count = 5.0
    nosy_names = ['gvanrossum', 'rhettinger', 'benjamin.peterson', 'serhiy.storchaka', 'brandtbucher']
    pr_nums = ['29540']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue45791'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Review python/cpython#29540 and the BPO 45791 discussion first; the issue names no source files or tests. Done means resolving the reported instancecheck lookup issue and completing the corresponding patch review.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    compilers
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.