python / python/cpython

chdir __exit__ is not safe

Open
#89,708 15 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.11 stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 45545
Nosy @warsaw, @eryksun, @FFY00, @ucodery
PRs
  • python/cpython#29218
  • python/cpython#29220
  • Files
  • test_chdir.py: minimal test script
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2021-10-20.22:54:45.172>
    labels = ['type-bug', '3.11']
    title = 'chdir __exit__ is not safe'
    updated_at = <Date 2021-10-26.17:30:32.350>
    user = 'https://github.com/ucodery'
    

    bugs.python.org fields:

    activity = <Date 2021-10-26.17:30:32.350>
    actor = 'ucodery'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = []
    creation = <Date 2021-10-20.22:54:45.172>
    creator = 'ucodery'
    dependencies = []
    files = ['50377']
    hgrepos = []
    issue_num = 45545
    keywords = ['patch']
    message_count = 14.0
    messages = ['404534', '404550', '404552', '404557', '404568', '404613', '404718', '405011', '405012', '405019', '405021', '405022', '405025', '405052']
    nosy_count = 4.0
    nosy_names = ['barry', 'eryksun', 'FFY00', 'ucodery']
    pr_nums = ['29218', '29220']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue45545'
    versions = ['Python 3.11']
    

    Linked PRs
    • gh-132982

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with the minimal reproduction in test_chdir.py and review the existing PRs 29218, 29220, and gh-132982 to understand the proposed direction. Run the reproduction, then trace the chdir context manager implementation and its tests. Done means the unsafe exit behavior is covered by a regression test and the reproduction no longer fails.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    operating-systems
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.