unittest.mock.patch does not work as a decorator on generator functions

Open
#88,893 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Start with the linked example_patch_failure.py, which demonstrates the failure when patching len on a generator function, then review the existing PR 27315 for the proposed direction. Done means unittest.mock.patch works as a decorator on generator functions without breaking the demonstrated use case.

Written by the indexing model from the issue text.

Description

3.8 (EOL) stdlib type-feature
BPO 44730
Nosy @gmjw
PRs
  • python/cpython#27315
    		•
    Files
  • example_patch_failure.py: Example of failure on simple patch of len
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2021-07-23.23:38:41.484>
labels = ['3.8', 'type-feature', 'library']
title = 'unittest.mock.patch does not work as a decorator on generator functions'
updated_at = <Date 2021-07-24.00:57:01.742>
user = 'https://github.com/gmjw'

    bugs.python.org fields:

    activity = <Date 2021-07-24.00:57:01.742>
actor = 'garethmjwilliams'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-07-23.23:38:41.484>
creator = 'garethmjwilliams'
dependencies = []
files = ['50176']
hgrepos = []
issue_num = 44730
keywords = ['patch']
message_count = 1.0
messages = ['398104']
nosy_count = 1.0
nosy_names = ['garethmjwilliams']
pr_nums = ['27315']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue44730'
versions = ['Python 3.8']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.