python / python/cpython

implementations of the deprecated load_module import loader API, as prescribed by the documentation, are not thread safe

Open
#87,824 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.10 3.7 (EOL) 3.8 (EOL) 3.9 (EOL) docs topic-importlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 43658
Nosy @kale-smoothie
Files
  • thread_unsafe_import.py: set env var PICK_API=N with N in {0,1} to demonstrate thread unsafe import and N=2 for expected behaviour
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2021-03-29.16:53:01.049>
    labels = ['type-bug', '3.8', '3.9', '3.10', '3.7', 'docs']
    title = 'implementations of the deprecated load_module import loader API, as prescribed by the documentation, are not thread safe'
    updated_at = <Date 2021-03-29.16:53:01.049>
    user = 'https://github.com/kale-smoothie'
    

    bugs.python.org fields:

    activity = <Date 2021-03-29.16:53:01.049>
    actor = 'kale-smoothie'
    assignee = 'docs@python'
    closed = False
    closed_date = None
    closer = None
    components = ['Documentation']
    creation = <Date 2021-03-29.16:53:01.049>
    creator = 'kale-smoothie'
    dependencies = []
    files = ['49916']
    hgrepos = []
    issue_num = 43658
    keywords = []
    message_count = 1.0
    messages = ['389713']
    nosy_count = 2.0
    nosy_names = ['docs@python', 'kale-smoothie']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue43658'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with the uploaded thread_unsafe_import.py reproduction and run it with PICK_API=0, 1, and 2 to observe the documented load_module behavior. Then locate the Python documentation for the deprecated import loader API and compare its prescribed implementation with the reproduction. Done means the documentation no longer prescribes a thread-unsafe implementation and accurately describes the expected behavior.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    documentation
    Issue type
    Documentation
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    35/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.