python / python/cpython

Dict copy optimization violates subclass invariant

Open
#87,412 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

interpreter-core type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 43246
Nosy @rhettinger, @jab, @methane, @serhiy-storchaka, @MojoVampire, @pgjones

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-02-17.22:12:32.940>
labels = ['type-bug']
title = 'Dict copy optimization violates subclass invariant'
updated_at = <Date 2021-02-19.02:54:18.442>
user = 'https://github.com/jab'

bugs.python.org fields:

activity = <Date 2021-02-19.02:54:18.442>
actor = 'methane'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2021-02-17.22:12:32.940>
creator = 'jab'
dependencies = []
files = []
hgrepos = []
issue_num = 43246
keywords = []
message_count = 4.0
messages = ['387191', '387198', '387206', '387279']
nosy_count = 6.0
nosy_names = ['rhettinger', 'jab', 'methane', 'serhiy.storchaka', 'josh.r', 'pgjones']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43246'
versions = []

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named in the issue. Start by reviewing BPO issue 43246 and the CPython implementation and tests for dict copying and subclass behavior. Done means the copy optimization no longer violates the subclass invariant and the behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.