python / python/cpython

make shutil.make_archive always accept pathlib objects

Open
#85,809 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.15 stdlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 41643
Nosy @graingert
PRs
  • python/cpython#21962
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-08-26.10:55:12.392>
    labels = ['3.7', '3.8', 'type-bug', 'library']
    title = 'make shutil.make_archive always accept pathlib objects'
    updated_at = <Date 2020-08-26.11:09:29.339>
    user = 'https://github.com/graingert'
    

    bugs.python.org fields:

    activity = <Date 2020-08-26.11:09:29.339>
    actor = 'graingert'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-08-26.10:55:12.392>
    creator = 'graingert'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41643
    keywords = ['patch']
    message_count = 1.0
    messages = ['375927']
    nosy_count = 1.0
    nosy_names = ['graingert']
    pr_nums = ['21962']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue41643'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    

    Linked PRs
    • gh-143668

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reading the shutil.make_archive entry point and the issue's linked PRs, including python/cpython#21962 and gh-143668. Check how pathlib objects are handled and identify the relevant library tests; done means pathlib inputs are accepted consistently and the tests pass.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    tooling
    Issue type
    Bug
    Difficulty
    2/5
    Estimated time
    1-3 hours
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.