python / python/cpython

Let fnmatch.filter accept a tuple of patterns

Open
#85,601 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stdlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 41429
Nosy @serhiy-storchaka, @andresdelfino
PRs
  • python/cpython#21666
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-07-28.23:41:58.851>
    labels = ['type-feature', 'library']
    title = 'Let fnmatch.filter accept a tuple of patterns'
    updated_at = <Date 2020-12-12.16:20:38.737>
    user = 'https://github.com/andresdelfino'
    

    bugs.python.org fields:

    activity = <Date 2020-12-12.16:20:38.737>
    actor = 'adelfino'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-07-28.23:41:58.851>
    creator = 'adelfino'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41429
    keywords = ['patch']
    message_count = 2.0
    messages = ['374540', '382916']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'adelfino']
    pr_nums = ['21666']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue41429'
    versions = []
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start at the fnmatch.filter entry point and inspect how its pattern argument is handled. Confirm the intended behavior for accepting a tuple of patterns, while preserving existing behavior for current inputs; the change is done when tuple input is covered and works as requested.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    api
    Issue type
    Feature
    Difficulty
    2/5
    Estimated time
    1-3 hours
    Activity status
    Stale
    Clarity
    Clearly specified
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.