python / python/cpython

SocketHandler silently drops log messages on re-connect

Open
#84,532 17 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.8 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 40352
Nosy @vsajip, @serhiy-storchaka, @remilapeyre
PRs
  • python/cpython#22061
  • Files
  • Archive.zip: test client and server to reproduce the issue
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-04-21.13:02:07.496>
    labels = ['3.8', 'type-bug', 'library']
    title = 'SocketHandler silently drops log messages on re-connect'
    updated_at = <Date 2020-10-14.15:36:25.488>
    user = 'https://bugs.python.org/OlegNykolyn'
    

    bugs.python.org fields:

    activity = <Date 2020-10-14.15:36:25.488>
    actor = 'Oleg Nykolyn'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-04-21.13:02:07.496>
    creator = 'Oleg Nykolyn'
    dependencies = []
    files = ['49080']
    hgrepos = []
    issue_num = 40352
    keywords = ['patch']
    message_count = 8.0
    messages = ['366920', '366925', '366929', '376190', '376217', '376229', '376844', '378625']
    nosy_count = 4.0
    nosy_names = ['vinay.sajip', 'serhiy.storchaka', 'remi.lapeyre', 'Oleg Nykolyn']
    pr_nums = ['22061']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue40352'
    versions = ['Python 3.8']
    

    Linked PRs
    • gh-154540

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reviewing the linked pull request gh-154540 and the Archive.zip reproduction attached to the issue. Then inspect Python's SocketHandler implementation and its logging tests; done means the reconnect behavior is covered by a regression test and messages are no longer silently dropped.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.