python / python/cpython

modulefinder chokes on numpy - dereferencing None in spec.loader

Open
#84,530 11 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

3.12 3.13 3.14 stdlib topic-importlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 40350
Nosy @warsaw, @ericvsmith, @ericsnowcurrently, @FFY00, @caje731
PRs
  • python/cpython#19917
  • python/cpython#29196
  • Files
  • fulllog.txt
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-04-21.07:33:37.811>
    labels = ['3.8', 'type-bug', 'library', '3.9']
    title = 'modulefinder chokes on numpy - dereferencing None in spec.loader'
    updated_at = <Date 2021-10-23.21:13:12.303>
    user = 'https://bugs.python.org/GregWhiteley'
    

    bugs.python.org fields:

    activity = <Date 2021-10-23.21:13:12.303>
    actor = 'FFY00'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-04-21.07:33:37.811>
    creator = 'Greg Whiteley'
    dependencies = []
    files = ['49079']
    hgrepos = []
    issue_num = 40350
    keywords = ['patch']
    message_count = 6.0
    messages = ['366912', '367856', '367943', '368112', '380087', '404911']
    nosy_count = 7.0
    nosy_names = ['barry', 'eric.smith', 'dkasak', 'eric.snow', 'FFY00', 'cajetan.rodrigues', 'Greg Whiteley']
    pr_nums = ['19917', '29196']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue40350'
    versions = ['Python 3.8', 'Python 3.9']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reading fulllog.txt and the existing PRs referenced in the issue, then trace how modulefinder handles numpy and accesses spec.loader. Confirm the None dereference and define done as handling this numpy case without crashing, with regression coverage identified from the existing patch discussion.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    tooling
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.