python / python/cpython

Incorrect error handling in unittest.mock

Open
#84,307 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.7 (EOL) 3.8 (EOL) 3.9 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 40126
Nosy @ncoghlan, @cjw296, @voidspace, @serhiy-storchaka, @tirkarthi, @bpmcl
PRs
  • python/cpython#19338
  • python/cpython#19351
  • python/cpython#19483
  • python/cpython#19484
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-03-31.16:07:24.415>
    labels = ['3.7', '3.8', 'type-bug', 'library', '3.9']
    title = 'Incorrect error handling in unittest.mock'
    updated_at = <Date 2020-04-12.11:57:36.107>
    user = 'https://github.com/bpmcl'
    

    bugs.python.org fields:

    activity = <Date 2020-04-12.11:57:36.107>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-03-31.16:07:24.415>
    creator = 'bmclarnon'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 40126
    keywords = ['patch']
    message_count = 8.0
    messages = ['365395', '365707', '365728', '366195', '366222', '366238', '366239', '366241']
    nosy_count = 6.0
    nosy_names = ['ncoghlan', 'cjw296', 'michael.foord', 'serhiy.storchaka', 'xtreak', 'bmclarnon']
    pr_nums = ['19338', '19351', '19483', '19484']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue40126'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    The issue identifies unittest.mock and links BPO issue 40126 plus PRs 19338, 19351, 19483, and 19484; no source file, test, reproduction, or entry point is named. Review the linked issue and pull requests first to determine the intended error handling and whether work is already complete. The payload does not define a clear completion condition.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    testing-qa
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    15/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.