python / python/cpython

TextIOWrapper usage of IncrementalEncoder doesn't match documentation around `final=`

Open
#82,666 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

extension-modules topic-IO type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 38485
Nosy @benjaminp, @jamercee

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2019-10-15.14:22:34.158>
labels = ['3.8', 'type-bug', '3.7', '3.9', 'expert-IO']
title = 'BUG Modules/_io/texio.c'
updated_at = <Date 2019-10-15.15:42:43.658>
user = 'https://github.com/jamercee'

bugs.python.org fields:

activity = <Date 2019-10-15.15:42:43.658>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['IO']
creation = <Date 2019-10-15.14:22:34.158>
creator = 'jamercee'
dependencies = []
files = []
hgrepos = []
issue_num = 38485
keywords = []
message_count = 1.0
messages = ['354733']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'stutzbach', 'jamercee']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue38485'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8', 'Python 3.9']

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Modules/_io/texio.c and the IncrementalEncoder/TextIOWrapper documentation, then identify the documented final= behavior that diverges. Confirm the current behavior and bring the implementation and relevant tests into agreement with the documentation; the issue names no test file, so locating the relevant IO tests is part of the investigation.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.