python / python/cpython

subprocess.list2cmdline() should not escape wrapping single/double quotes

Open
#81,840 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

3.9 (EOL) OS-windows stdlib topic-subprocess type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 37659
Nosy @pfmoore, @tjguk, @zware, @eryksun, @zooba, @kejxu

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2019-07-23.17:17:40.645>
labels = ['type-bug', '3.9', 'OS-windows']
title = 'subprocess.list2cmdline() should not escape wrapping single/double quotes'
updated_at = <Date 2019-07-24.18:47:58.688>
user = 'https://github.com/kejxu'

bugs.python.org fields:

activity = <Date 2019-07-24.18:47:58.688>
actor = 'steve.dower'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Windows']
creation = <Date 2019-07-23.17:17:40.645>
creator = 'kejxu'
dependencies = []
files = []
hgrepos = []
issue_num = 37659
keywords = []
message_count = 3.0
messages = ['348342', '348343', '348400']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'eryksun', 'steve.dower', 'kejxu']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37659'
versions = ['Python 3.9']

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the subprocess.list2cmdline() entry point and inspect how Windows command-line arguments containing wrapping single or double quotes are handled. Look for existing subprocess tests covering command-line quoting, then add coverage showing the expected unescaped wrapping quotes; done means the behavior matches the issue title.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.