python / python/cpython

Mocking a MagicMock with a function spec results in an AsyncMock

Open
#81,432 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.8 (EOL) 3.9 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 37251
Nosy @lisroach, @hroncok, @mariocj89, @miss-islington, @tirkarthi, @jeremycline, @msuozzo
PRs
  • python/cpython#14117
  • python/cpython#15830
  • python/cpython#15837
  • python/cpython#25347
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-06-12.14:00:18.556>
    labels = ['3.8', 'type-bug', 'library', '3.9']
    title = 'Mocking a MagicMock with a function spec results in an AsyncMock'
    updated_at = <Date 2021-04-11.17:20:48.974>
    user = 'https://github.com/jeremycline'
    

    bugs.python.org fields:

    activity = <Date 2021-04-11.17:20:48.974>
    actor = 'matthew.suozzo'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-06-12.14:00:18.556>
    creator = 'jcline'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37251
    keywords = ['patch']
    message_count = 11.0
    messages = ['345358', '345377', '345399', '345704', '346091', '346150', '346583', '351385', '351621', '351644', '390689']
    nosy_count = 7.0
    nosy_names = ['lisroach', 'hroncok', 'mariocj89', 'miss-islington', 'xtreak', 'jcline', 'matthew.suozzo']
    pr_nums = ['14117', '15830', '15837', '25347']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue37251'
    versions = ['Python 3.8', 'Python 3.9']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with the Library (Lib) component and review the four linked pull requests to understand the proposed handling of MagicMock, function specs, and AsyncMock. Completion means resolving the reported behavior and bringing the issue out of its open patch-review state.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    testing-qa
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    20/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.