python / python/cpython

functools.singledispatchmethod interacts poorly with subclasses

Open
#80,638 9 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

3.8 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 36457
Nosy @methane, @ambv, @tim-mitchell
Files
  • methoddispatch36.py: alternate implementation from methoddispatch package
  • singledispatchmethod.py: improved implementation
  • singledispatchmethod.py
  • test_sdm.py: implementation tests
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-03-28.03:42:39.296>
    labels = ['3.8', 'type-bug', 'library']
    title = 'functools.singledispatchmethod interacts poorly with subclasses'
    updated_at = <Date 2022-03-18.06:10:24.323>
    user = 'https://github.com/tim-mitchell'
    

    bugs.python.org fields:

    activity = <Date 2022-03-18.06:10:24.323>
    actor = 'Tim Mitchell2'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-03-28.03:42:39.296>
    creator = 'Tim Mitchell2'
    dependencies = []
    files = ['48235', '48261', '50688', '50689']
    hgrepos = []
    issue_num = 36457
    keywords = []
    message_count = 5.0
    messages = ['339008', '340005', '370758', '371014', '415470']
    nosy_count = 5.0
    nosy_names = ['methane', 'lukasz.langa', 'Tim Mitchell2', 'dschaumont', 'bojan.jovanovic.gtech']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue36457'
    versions = ['Python 3.8']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reading singledispatchmethod.py and the accompanying test_sdm.py implementation tests, then compare them with the reported subclass interaction. Done means the intended subclass behavior is established in regression tests and the implementation passes them.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.