python / python/cpython

pkgutil.get_importer only return the first valid path_hook(importer)

Open
#80,634 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.7 (EOL) 3.8 (EOL) 3.9 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
Avg merge
1d 9h
Merged PRs (30d)
558

Description

BPO 36453
Nosy @tiran, @Windsooon
PRs
  • python/cpython#19921
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-03-28.00:11:08.664>
    labels = ['3.7', '3.8', 'type-bug', 'library', '3.9']
    title = 'pkgutil.get_importer only return the first valid path_hook(importer)'
    updated_at = <Date 2020-05-05.11:54:37.129>
    user = 'https://github.com/Windsooon'
    

    bugs.python.org fields:

    activity = <Date 2020-05-05.11:54:37.129>
    actor = 'christian.heimes'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-03-28.00:11:08.664>
    creator = 'Windson Yang'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36453
    keywords = ['patch']
    message_count = 3.0
    messages = ['339000', '339057', '365141']
    nosy_count = 2.0
    nosy_names = ['christian.heimes', 'Windson Yang']
    pr_nums = ['19921']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue36453'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by locating pkgutil.get_importer in the Lib component and review the historical PR python/cpython#19921, since the issue is marked patch review. Confirm the intended behavior from the title: only the first valid path_hook importer should be returned, with tests covering that behavior before considering the work done.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    tooling
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.