python / python/cpython

urlparse of urllib returns wrong hostname

Open
#80,519 16 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

3.10 3.11 3.7 (EOL) 3.8 (EOL) 3.9 (EOL) stdlib type-security
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 36338
Nosy @ronaldoussoren, @orsenthil, @tiran, @vadmium, @matrixise, @tirkarthi, @jpic, @iritkatriel
PRs
  • python/cpython#14896
  • python/cpython#16780
  • Files
  • test_bug_36338.py: Unittest for this issue.
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-03-18.08:06:11.906>
    labels = ['type-security', '3.8', '3.9', '3.10', '3.11', '3.7', 'library']
    title = 'urlparse of urllib returns wrong hostname'
    updated_at = <Date 2021-12-03.00:01:27.917>
    user = 'https://bugs.python.org/sanebow'
    

    bugs.python.org fields:

    activity = <Date 2021-12-03.00:01:27.917>
    actor = 'vstinner'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-03-18.08:06:11.906>
    creator = 'sanebow'
    dependencies = []
    files = ['48215']
    hgrepos = []
    issue_num = 36338
    keywords = ['patch']
    message_count = 14.0
    messages = ['338171', '338172', '338173', '338599', '338960', '338972', '349153', '351511', '351589', '351590', '354634', '354746', '355322', '407558']
    nosy_count = 9.0
    nosy_names = ['ronaldoussoren', 'orsenthil', 'christian.heimes', 'martin.panter', 'matrixise', 'xtreak', 'sanebow', 'jpic', 'iritkatriel']
    pr_nums = ['14896', '16780']
    priority = 'high'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'security'
    url = 'https://bugs.python.org/issue36338'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10', 'Python 3.11']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reading and running test_bug_36338.py, then inspect the existing PRs #14896 and #16780 for the current handling of urllib URL parsing. Done means the reported input produces the correct hostname and the regression test passes.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend, security
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.