python / python/cpython

urllib.error.HTTPError.fp is not closed when error is finalized on Windows

Open
#79,139 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.10 3.11 3.9 (EOL) OS-windows stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
Avg merge
1d 9h
Merged PRs (30d)
558

Description

BPO 34958
Nosy @pfmoore, @orsenthil, @tjguk, @zware, @zooba, @puxlit

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2018-10-11.13:49:09.650>
labels = ['type-bug', '3.9', '3.10', '3.11', 'library', 'OS-windows']
title = 'urllib.error.HTTPError.fp is not closed when error is finalized on Windows'
updated_at = <Date 2021-10-22.19:07:56.786>
user = 'https://github.com/puxlit'

bugs.python.org fields:

activity = <Date 2021-10-22.19:07:56.786>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)', 'Windows']
creation = <Date 2018-10-11.13:49:09.650>
creator = 'puxlit'
dependencies = []
files = []
hgrepos = []
issue_num = 34958
keywords = []
message_count = 1.0
messages = ['327532']
nosy_count = 6.0
nosy_names = ['paul.moore', 'orsenthil', 'tim.golden', 'zach.ware', 'steve.dower', 'puxlit']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34958'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the urllib.error.HTTPError entry point and tracing how its fp is handled when the error is finalized on Windows. Reproduce the reported behavior with a Windows-focused test, then verify that fp is closed after finalization without changing other HTTPError behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.