python / python/cpython

ipaddress should accept bytearray in addition to bytes

Open
#78,646 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stdlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 34465
Nosy @gpshead, @ncoghlan, @serhiy-storchaka, @zhangyangyu, @joernheissler, @prudvinit
PRs
  • python/cpython#8908
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2018-08-22.19:48:00.413>
    labels = ['3.8', 'type-feature', 'library']
    title = 'ipaddress should accept bytearray in addition to bytes'
    updated_at = <Date 2018-09-11.16:35:00.331>
    user = 'https://github.com/joernheissler'
    

    bugs.python.org fields:

    activity = <Date 2018-09-11.16:35:00.331>
    actor = 'joernheissler'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2018-08-22.19:48:00.413>
    creator = 'joernheissler'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34465
    keywords = ['patch']
    message_count = 10.0
    messages = ['323906', '323982', '324047', '324050', '324051', '324052', '324437', '324969', '325017', '325024']
    nosy_count = 7.0
    nosy_names = ['gregory.p.smith', 'ncoghlan', 'pmoody', 'serhiy.storchaka', 'xiang.zhang', 'joernheissler', 'prudvinit']
    pr_nums = ['8908']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue34465'
    versions = ['Python 3.8']
    

    Linked PRs
    • gh-135811

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by inspecting the Python ipaddress library entry points and its existing tests for byte inputs. Confirm how bytearray values are currently handled, then update the behavior and tests so bytearray is accepted wherever bytes is accepted; the relevant ipaddress tests should pass when done.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    networking
    Issue type
    Feature
    Difficulty
    2/5
    Estimated time
    1-3 hours
    Activity status
    Stale
    Clarity
    Clearly specified
    Newbie friendliness
    20/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.