[Windows] samefile() should not use zero-valued st_dev and st_ino

Open
#78,116 13 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
operating-systems

Research direction

Start by locating the Windows implementation and tests for samefile(); the issue identifies st_dev and st_ino as the relevant values. Confirm the Windows behavior does not rely on zero-valued values, and add or update coverage demonstrating the corrected behavior.

Written by the indexing model from the issue text.

Description

3.10 3.8 (EOL) 3.9 (EOL) extension-modules OS-windows stdlib type-bug
BPO 33935
Nosy @pfmoore, @giampaolo, @tjguk, @bitdancer, @zware, @eryksun, @zooba, @https://github.com/alexkowel

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2018-06-22.00:38:26.469>
labels = ['type-bug', '3.8', '3.9', '3.10', 'extension-modules', 'library', 'OS-windows']
title = '[Windows] samefile() should not use zero-valued st_dev and st_ino'
updated_at = <Date 2021-03-21.05:25:57.088>
user = 'https://bugs.python.org/DenizBozyigit'

bugs.python.org fields:

activity = <Date 2021-03-21.05:25:57.088>
actor = 'eryksun'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules', 'Library (Lib)', 'Windows']
creation = <Date 2018-06-22.00:38:26.469>
creator = 'Deniz Bozyigit'
dependencies = []
files = []
hgrepos = []
issue_num = 33935
keywords = []
message_count = 13.0
messages = ['320199', '320201', '320202', '320204', '320210', '320243', '335770', '335771', '335881', '335977', '336034', '387145', '387519']
nosy_count = 10.0
nosy_names = ['paul.moore', 'giampaolo.rodola', 'tim.golden', 'r.david.murray', 'zach.ware', 'eryksun', 'steve.dower', 'Deniz Bozyigit', 'gary ruben', 'alexkowel']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33935'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

Dominant language
Python
Stars
77.2k
Forks
36k
Avg merge
1d 9h
Merged PRs (30d)
558

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/cpython

All issues in python/cpython

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.