python / python/cpython

Improve exception message in ast.literal_eval

Open
#77,069 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.8 (EOL) stdlib
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 32888
Nosy @briancurtin, @Rosuav, @serhiy-storchaka
PRs
  • python/cpython#340
  • python/cpython#16620
  • python/cpython#17662
  • Dependencies
  • bpo-32892: Remove specific constant AST types in favor of ast.Constant
  • bpo-32893: ast.literal_eval() shouldn't accept booleans as numbers in AST
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2018-02-20.17:26:21.508>
    labels = ['3.8', 'library']
    title = 'Improve exception message in ast.literal_eval'
    updated_at = <Date 2019-12-19.15:26:59.362>
    user = 'https://github.com/Rosuav'
    

    bugs.python.org fields:

    activity = <Date 2019-12-19.15:26:59.362>
    actor = 'BTaskaya'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2018-02-20.17:26:21.508>
    creator = 'Rosuav'
    dependencies = ['32892', '32893']
    files = []
    hgrepos = []
    issue_num = 32888
    keywords = ['patch']
    message_count = 6.0
    messages = ['312423', '312424', '312427', '312429', '312442', '320993']
    nosy_count = 3.0
    nosy_names = ['brian.curtin', 'Rosuav', 'serhiy.storchaka']
    pr_nums = ['340', '16620', '17662']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue32888'
    versions = ['Python 3.8']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start at ast.literal_eval and review PRs #340, #16620, and #17662, along with dependencies bpo-32892 and bpo-32893. The issue does not name files, tests, affected cases, or target wording, so confirm the intended exception-message behavior before defining completion.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    compilers
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    20/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.