python / python/cpython

isinstance is calling ob.__getattribute__ as a fallback instead of object.__class__.__get__

Open
#76,864 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.7 (EOL) interpreter-core stdlib
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 32683
Nosy @rhettinger, @pfmoore, @stevendaprano, @bitdancer, @ethanfurman, @mr-nfamous, @P403n1x87

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2018-01-26.21:10:40.522>
labels = ['interpreter-core', '3.7', 'library']
title = 'isinstance is calling ob.__getattribute__ as a fallback instead of object.__class__.__get__'
updated_at = <Date 2021-12-10.11:41:23.463>
user = 'https://github.com/mr-nfamous'

bugs.python.org fields:

activity = <Date 2021-12-10.11:41:23.463>
actor = 'steven.daprano'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core', 'Library (Lib)']
creation = <Date 2018-01-26.21:10:40.522>
creator = 'bup'
dependencies = []
files = []
hgrepos = []
issue_num = 32683
keywords = []
message_count = 16.0
messages = ['310793', '310814', '310823', '408122', '408128', '408131', '408133', '408135', '408136', '408141', '408165', '408170', '408171', '408172', '408188', '408192']
nosy_count = 7.0
nosy_names = ['rhettinger', 'paul.moore', 'steven.daprano', 'r.david.murray', 'ethan.furman', 'bup', 'Gabriele Tornetta']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue32683'
versions = ['Python 3.7']

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files, tests, or entry points are named in the issue. Start by reproducing the isinstance behavior described in the title and tracing the interpreter-core and library implementation; done means the fallback behavior is corrected and covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.