python / python/cpython

Fallback to dev_urandom doesn't work when py_getrandom returns -1

Open
#76,761 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

build
Dominant language
Python
Stars
77.2k
Forks
36k
Avg merge
1d 9h
Merged PRs (30d)
558

Description

BPO 32580
Nosy @vstinner, @jernejs
Files
  • random_fallback.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2018-01-17.13:11:08.071>
    labels = ['build']
    title = "Fallback to dev_urandom doesn't work when py_getrandom returns -1"
    updated_at = <Date 2018-01-17.20:52:10.985>
    user = 'https://github.com/jernejs'
    

    bugs.python.org fields:

    activity = <Date 2018-01-17.20:52:10.985>
    actor = 'jernejs'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Build']
    creation = <Date 2018-01-17.13:11:08.071>
    creator = 'jernejs'
    dependencies = []
    files = ['47389']
    hgrepos = []
    issue_num = 32580
    keywords = ['patch']
    message_count = 5.0
    messages = ['310158', '310162', '310196', '310197', '310206']
    nosy_count = 2.0
    nosy_names = ['vstinner', 'jernejs']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue32580'
    versions = ['Python 3.5', 'Python 3.6']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reviewing the attached random_fallback.patch and locating the implementation of py_getrandom and its dev_urandom fallback in CPython. Trace the behavior when py_getrandom returns -1, then run the relevant random and build tests if available. Done means the fallback works for that return value without breaking existing entropy-source behavior.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    operating-systems
    Issue type
    Bug
    Difficulty
    3/5
    Estimated time
    1-2 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    35/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.