python / python/cpython

_io.IncrementalNewlineDecoder doesn't inherit codecs.IncrementalDecoder

Open
#75,903 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stdlib topic-IO type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 31722
Nosy @benjaminp, @serhiy-storchaka, @zhangyangyu, @corona10
PRs
  • python/cpython#16664
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2017-10-07.14:26:41.466>
    labels = ['3.7', '3.8', 'type-bug', 'library', 'expert-IO']
    title = "_io.IncrementalNewlineDecoder doesn't inherit codecs.IncrementalDecoder"
    updated_at = <Date 2019-10-08.18:46:56.963>
    user = 'https://github.com/serhiy-storchaka'
    

    bugs.python.org fields:

    activity = <Date 2019-10-08.18:46:56.963>
    actor = 'corona10'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)', 'IO']
    creation = <Date 2017-10-07.14:26:41.466>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31722
    keywords = ['patch']
    message_count = 3.0
    messages = ['303879', '303880', '328293']
    nosy_count = 5.0
    nosy_names = ['benjamin.peterson', 'stutzbach', 'serhiy.storchaka', 'xiang.zhang', 'corona10']
    pr_nums = ['16664']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue31722'
    versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by inspecting the _io.IncrementalNewlineDecoder and codecs.IncrementalDecoder entry points, then review the existing python/cpython#16664 pull request. Confirm the intended inheritance behavior and identify the relevant IO tests before making changes; done means the decoder follows the expected IncrementalDecoder interface and the tests pass.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Bug
    Difficulty
    3/5
    Estimated time
    1-2 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    20/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.