python / python/cpython

urlencode should accept generator as values for mappings when doseq=True

Open
#75,887 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.8 (EOL) stdlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
Avg merge
1d 9h
Merged PRs (30d)
558

Description

BPO 31706
Nosy @orsenthil, @taleinat, @serhiy-storchaka, @francoisfreitag
PRs
  • python/cpython#3901
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2017-10-05.20:12:52.109>
    labels = ['3.8', 'type-feature', 'library']
    title = 'urlencode should accept generator as values for mappings when doseq=True'
    updated_at = <Date 2019-08-25.11:04:53.916>
    user = 'https://github.com/francoisfreitag'
    

    bugs.python.org fields:

    activity = <Date 2019-08-25.11:04:53.916>
    actor = 'taleinat'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2017-10-05.20:12:52.109>
    creator = 'francois.freitag'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31706
    keywords = ['patch']
    message_count = 4.0
    messages = ['303784', '303806', '306908', '350449']
    nosy_count = 4.0
    nosy_names = ['orsenthil', 'taleinat', 'serhiy.storchaka', 'francois.freitag']
    pr_nums = ['3901']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue31706'
    versions = ['Python 3.8']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with Python's urlencode implementation and review the existing pull request #3901. Confirm the expected behavior for mappings whose values are generators when doseq=True, then verify that the relevant library tests cover the change.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Feature
    Difficulty
    3/5
    Estimated time
    1-2 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.