python / python/cpython

PyStructSequence_New() doesn't validate its input type (crashes in os.wait3() and os.wait4() in case of a bad resource.struct_rusage)

Open
#75,754 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.10 3.11 3.9 (EOL) extension-modules type-crash
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 31573
Nosy @vstinner, @serhiy-storchaka, @orenmn, @iritkatriel
PRs
  • python/cpython#3750
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2017-09-25.10:29:33.947>
    labels = ['extension-modules', '3.10', '3.9', 'type-crash', '3.11']
    title = "PyStructSequence_New() doesn't validate its input type (crashes in os.wait3() and os.wait4() in case of a bad resource.struct_rusage)"
    updated_at = <Date 2021-10-18.23:14:00.500>
    user = 'https://github.com/orenmn'
    

    bugs.python.org fields:

    activity = <Date 2021-10-18.23:14:00.500>
    actor = 'iritkatriel'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2017-09-25.10:29:33.947>
    creator = 'Oren Milman'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31573
    keywords = ['patch']
    message_count = 3.0
    messages = ['302945', '302958', '404243']
    nosy_count = 4.0
    nosy_names = ['vstinner', 'serhiy.storchaka', 'Oren Milman', 'iritkatriel']
    pr_nums = ['3750']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'crash'
    url = 'https://bugs.python.org/issue31573'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by locating PyStructSequence_New() and the os.wait3() and os.wait4() entry points, then review the existing context and PR #3750. Done means a malformed resource.struct_rusage no longer causes these calls to crash and the behavior is covered by an appropriate regression test.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    operating-systems
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.