python / python/cpython

Mock with spec object does not ensure method call signatures

Open
#74,772 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 30587
Nosy @cjw296, @voidspace, @phmc, @mariocj89, @bclau, @tirkarthi
PRs
  • python/cpython#1982
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2017-06-07.12:04:06.898>
    labels = ['3.8', 'type-bug', 'library']
    title = 'Mock with spec object does not ensure method call signatures'
    updated_at = <Date 2019-11-07.16:48:26.232>
    user = 'https://github.com/bclau'
    

    bugs.python.org fields:

    activity = <Date 2019-11-07.16:48:26.232>
    actor = 'breilly_box'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2017-06-07.12:04:06.898>
    creator = 'cbelu'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 30587
    keywords = ['patch']
    message_count = 5.0
    messages = ['295335', '339269', '339289', '351610', '351617']
    nosy_count = 7.0
    nosy_names = ['cjw296', 'michael.foord', 'pconnell', 'mariocj89', 'cbelu', 'xtreak', 'breilly_box']
    pr_nums = ['1982']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue30587'
    versions = ['Python 3.8']
    

    Linked PRs
    • gh-122128
    • gh-154080

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Review the migrated BPO issue and the linked PRs gh-122128 and gh-154080 first, since they contain the available discussion and implementation context. Confirm how spec-object mocks currently handle method call signatures, then verify that the reported behavior is addressed and covered by the relevant tests identified in those PRs.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    testing-qa
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    20/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.