In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

Open
#74,133 20 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Documentation
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
documentation

Research direction

Start with the SocketServer RequestHandlerClass entry point and read Issue29947_for_discussion_04.patch. Review the existing discussion and PR 1496 before deciding whether documentation or behavior is intended; done means the class-versus-factory usage is resolved and clearly documented.

Written by the indexing model from the issue text.

Description

3.7 (EOL) docs stdlib topic-socket type-bug
BPO 29947
Nosy @ericvsmith, @bitdancer, @vadmium, @MaharishiCanada
PRs
  • python/cpython#1496
    		•
    Files
  • Issue29947_for_discussion_04.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2017-03-30.12:08:53.784>
labels = ['3.7', 'type-bug', 'library', 'docs']
title = 'In SocketServer, why not passing a factory instance for the RequestHandlerClass  instead of the class itself?'
updated_at = <Date 2017-05-08.04:16:49.390>
user = 'https://github.com/MaharishiCanada'

    bugs.python.org fields:

    activity = <Date 2017-05-08.04:16:49.390>
actor = 'louielu'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation', 'Library (Lib)']
creation = <Date 2017-03-30.12:08:53.784>
creator = 'dominic108'
dependencies = []
files = ['46781']
hgrepos = []
issue_num = 29947
keywords = ['patch']
message_count = 20.0
messages = ['290840', '290855', '290886', '290887', '290892', '290952', '290963', '290976', '290996', '291002', '291004', '291005', '291006', '291024', '291026', '291036', '291048', '291056', '291142', '291181']
nosy_count = 5.0
nosy_names = ['eric.smith', 'r.david.murray', 'docs@python', 'martin.panter', 'dominic108']
pr_nums = ['1496']
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue29947'
versions = ['Python 3.6', 'Python 3.7']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.