python / python/cpython

py_blake2*_new_impl produces inconsistent error messages, and raises OverflowError where ValueError might be better

Open
#74,021 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

extension-modules type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 29835
Nosy @tiran, @serhiy-storchaka, @zhangyangyu, @orenmn

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2017-03-17.12:08:00.055>
labels = ['type-bug', '3.7']
title = 'py_blake2*_new_impl produces inconsistent error messages, and raises OverflowError where ValueError might be better'
updated_at = <Date 2017-03-17.13:17:24.223>
user = 'https://github.com/orenmn'

bugs.python.org fields:

activity = <Date 2017-03-17.13:17:24.223>
actor = 'christian.heimes'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2017-03-17.12:08:00.055>
creator = 'Oren Milman'
dependencies = []
files = []
hgrepos = []
issue_num = 29835
keywords = []
message_count = 2.0
messages = ['289757', '289759']
nosy_count = 4.0
nosy_names = ['christian.heimes', 'serhiy.storchaka', 'xiang.zhang', 'Oren Milman']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue29835'
versions = ['Python 3.7']

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the py_blake2*_new_impl entry point named in the issue and review the migrated BPO details. Compare the affected error cases and determine the intended exception types and messages; the payload names no source file or test, so those must be located before defining completion.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.