python / python/cpython

pkgutil._iter_file_finder_modules should not be fooled by *.py folders

Open
#73,955 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.7 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 29769
Nosy @ncoghlan, @ericsnowcurrently, @wm75
Files
  • pkgutil.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2017-03-09.11:46:10.278>
    labels = ['3.7', 'type-bug', 'library']
    title = 'pkgutil._iter_file_finder_modules should not be fooled by *.py folders'
    updated_at = <Date 2017-03-10.02:04:13.571>
    user = 'https://github.com/wm75'
    

    bugs.python.org fields:

    activity = <Date 2017-03-10.02:04:13.571>
    actor = 'ncoghlan'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2017-03-09.11:46:10.278>
    creator = 'wolma'
    dependencies = []
    files = ['46714']
    hgrepos = []
    issue_num = 29769
    keywords = ['patch']
    message_count = 2.0
    messages = ['289285', '289333']
    nosy_count = 3.0
    nosy_names = ['ncoghlan', 'eric.snow', 'wolma']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue29769'
    versions = ['Python 3.7']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start at the pkgutil._iter_file_finder_modules entry point and review the linked pkgutil.patch to understand the reported behavior. Confirm that folders whose names end in .py are not treated as modules, and add or update coverage if the existing patch indicates where it belongs.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Bug
    Difficulty
    2/5
    Estimated time
    1-3 hours
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    35/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.