python / python/cpython

TarFile.extract() suffers from hard links inside tarball

Open
#73,798 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.7 (EOL) 3.8 (EOL) 3.9 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 29612
Nosy @gustaebel, @ethanfurman, @j0ack
PRs
  • python/cpython#5753
  • python/cpython#8700
  • python/cpython#16958
  • Files
  • tartest.py
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2017-02-21.10:10:46.770>
    labels = ['3.7', '3.8', 'type-bug', 'library', '3.9']
    title = 'TarFile.extract() suffers from hard links inside tarball'
    updated_at = <Date 2020-01-19.18:55:54.762>
    user = 'https://bugs.python.org/JussiJudin'
    

    bugs.python.org fields:

    activity = <Date 2020-01-19.18:55:54.762>
    actor = 'zach.ware'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2017-02-21.10:10:46.770>
    creator = 'Jussi Judin'
    dependencies = []
    files = ['46658']
    hgrepos = []
    issue_num = 29612
    keywords = ['patch']
    message_count = 7.0
    messages = ['288284', '289360', '312235', '312345', '312900', '314588', '320140']
    nosy_count = 6.0
    nosy_names = ['guettli', 'lars.gustaebel', 'ethan.furman', 'Jussi Judin', 'jtrouverie', 'Larry Cook']
    pr_nums = ['5753', '8700', '16958']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue29612'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with the attached tartest.py reproduction and the tarfile library implementation behind TarFile.extract(). Review the existing PRs #5753, #8700, and #16958 before making changes, then add or update coverage for hard links inside a tarball and confirm the extraction behavior with the relevant test suite.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    20/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.