python / python/cpython

smtplib send_message should add Date header if it is missing, per RFC5322

Open
#73,065 33 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

easy stdlib topic-email type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 28879
Nosy @bitdancer, @soltysh, @jenstroeger, @elafontaine
PRs
  • python/cpython#2655
  • python/cpython#5176
  • Files
  • issue_28879.patch
  • issue_28879_V2.patch
  • issue_28879_V3.patch
  • issue_28879_V4.patch: Python3 complete changes
  • issue_28879_python2.patch
  • issue_28879_python2_overkill.patch
  • issue28879_v5.patch
  • Resent_heuristic.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-12-05.15:48:15.178>
    labels = ['3.7', 'easy', 'type-bug', 'library']
    title = 'smtplib send_message should add Date header if it is missing, per RFC5322'
    updated_at = <Date 2018-09-08.23:03:27.435>
    user = 'https://bugs.python.org/HenningvonBargen'
    

    bugs.python.org fields:

    activity = <Date 2018-09-08.23:03:27.435>
    actor = '_savage'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2016-12-05.15:48:15.178>
    creator = 'Henning.von.Bargen'
    dependencies = []
    files = ['45929', '45958', '45959', '45969', '46001', '46002', '46459', '46460']
    hgrepos = []
    issue_num = 28879
    keywords = ['patch', 'easy']
    message_count = 32.0
    messages = ['282425', '282429', '282549', '282553', '282558', '283275', '283313', '283347', '283361', '283362', '283412', '283431', '283436', '283572', '283574', '283593', '283604', '283645', '283647', '283847', '283848', '283849', '285686', '285694', '285697', '286037', '286504', '286505', '288046', '297496', '297528', '324865']
    nosy_count = 5.0
    nosy_names = ['r.david.murray', 'maciej.szulik', 'Henning.von.Bargen', '_savage', 'Eric Lafontaine']
    pr_nums = ['2655', '5176']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue28879'
    versions = ['Python 3.6', 'Python 3.7']
    

    Linked PRs
    • gh-136850

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with the smtplib.send_message entry point and review the issue's RFC5322 requirement alongside the existing patch history. Check the linked PRs and related patches before making changes; done means the missing Date header behavior is resolved consistently and covered by the project's relevant tests.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    networking
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.