httplib/http.client HTTPConnection._set_hostport() regression

Open
#72,725 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Read HTTPConnection._set_hostport() in the httplib/http.client implementation and compare its behavior with the attached get_hostport.diff patch. Trace the reported regression in the affected HTTPConnection host/port handling; done means the regression is fixed without changing unrelated behavior.

Written by the indexing model from the issue text.

Description

3.7 (EOL) stdlib
BPO 28539
Nosy @vadmium, @zware, @cfs-pure
Files
  • get_hostport.diff: Fix to HTTPConnection._get_hostport()
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2016-10-26.19:12:47.192>
labels = ['3.7', 'library']
title = 'httplib/http.client HTTPConnection._set_hostport() regression'
updated_at = <Date 2016-10-29.02:48:34.915>
user = 'https://github.com/cfs-pure'

    bugs.python.org fields:

    activity = <Date 2016-10-29.02:48:34.915>
actor = 'martin.panter'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2016-10-26.19:12:47.192>
creator = 'cfs-pure'
dependencies = []
files = ['45233']
hgrepos = []
issue_num = 28539
keywords = ['patch']
message_count = 11.0
messages = ['279509', '279511', '279512', '279517', '279518', '279519', '279520', '279522', '279523', '279524', '279647']
nosy_count = 3.0
nosy_names = ['martin.panter', 'zach.ware', 'cfs-pure']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue28539'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.