python / python/cpython

Clean up division fast paths in Objects/longobject.c

Open
#72,247 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

interpreter-core performance type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 28060
Nosy @mdickinson, @pitrou, @serhiy-storchaka
Files
  • divmod_fastpath.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-09-10.10:46:13.057>
    labels = ['performance']
    title = 'Clean up division fast paths in Objects/longobject.c'
    updated_at = <Date 2017-07-22.10:09:56.204>
    user = 'https://github.com/mdickinson'
    

    bugs.python.org fields:

    activity = <Date 2017-07-22.10:09:56.204>
    actor = 'mark.dickinson'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = []
    creation = <Date 2016-09-10.10:46:13.057>
    creator = 'mark.dickinson'
    dependencies = []
    files = ['44528']
    hgrepos = []
    issue_num = 28060
    keywords = ['patch']
    message_count = 6.0
    messages = ['275618', '275619', '275675', '275679', '298843', '298845']
    nosy_count = 3.0
    nosy_names = ['mark.dickinson', 'pitrou', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'commit review'
    status = 'open'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue28060'
    versions = ['Python 3.6']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with Objects/longobject.c and inspect the attached divmod_fastpath.patch from BPO issue 28060. Trace the division fast paths addressed by the patch and compare the proposed cleanup with the current file. Done means the intended cleanup is incorporated without changing division behavior, but the issue does not name tests or a current validation command.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    c, python
    Domain
    backend, performance
    Issue type
    Refactor
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.