python / python/cpython

Diff for visually comparing actual with expected in mock.assert_called_with.

Open
#72,241 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stdlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 28054
Nosy @rhettinger, @cjw296, @voidspace, @asfaltboy, @mariocj89, @tirkarthi
Files
  • issue28054.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-09-09.22:44:33.486>
    labels = ['3.8', 'type-feature', 'tests']
    title = 'Diff for visually comparing actual with expected in mock.assert_called_with.'
    updated_at = <Date 2018-12-11.06:33:15.547>
    user = 'https://bugs.python.org/EliRose'
    

    bugs.python.org fields:

    activity = <Date 2018-12-11.06:33:15.547>
    actor = 'cjw296'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Tests']
    creation = <Date 2016-09-09.22:44:33.486>
    creator = 'Eli Rose'
    dependencies = []
    files = ['47982']
    hgrepos = []
    issue_num = 28054
    keywords = ['patch']
    message_count = 7.0
    messages = ['275481', '279319', '279394', '329636', '329653', '331433', '331583']
    nosy_count = 7.0
    nosy_names = ['rhettinger', 'cjw296', 'michael.foord', 'asfaltboy', 'Eli Rose', 'mariocj89', 'xtreak']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue28054'
    versions = ['Python 3.8']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reading the linked issue28054.diff attachment and inspect the tests component around mock.assert_called_with. Confirm how the proposed visual comparison is intended to appear, then run the relevant mock tests and ensure the expected-versus-actual diff behavior is covered.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    testing-qa
    Issue type
    Feature
    Difficulty
    3/5
    Estimated time
    1-2 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    35/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.